Skip to content

Remove propagate_scope #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Remove propagate_scope #4308

wants to merge 3 commits into from

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Apr 16, 2025 •
edited
Loading

Remove propagate_scope from ThreadingIntegration.

We added propagate_scope as a replacement for propagate_hub in the hubs & scopes refactor, but as this comment states:

Note: propagate_hub did not have any effect on propagation of scope data
scope data was always propagated no matter what the value of propagate_hub was
This is why the default for propagate_scope is True

So this is not actually a replacement for propagate_hub. Unless we have a usecase in mind which propagate_scope=False solves, let's just remove it.

I also checked public code on GitHub and no one sets propagate_scope to False.

@sentrivana sentrivana changed the title Remove propagate_scopes Remove propagate_scopes Apr 16, 2025
@sentrivana sentrivana marked this pull request as ready for review April 16, 2025 12:59
@sentrivana sentrivana requested a review from a team as a code owner April 16, 2025 12:59
@sentrivana sentrivana changed the title Remove propagate_scopes Remove propagate_scope Apr 16, 2025
@sentrivana sentrivana closed this Apr 16, 2025
@codecov
Copy link

codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (571ff3b) to head (9f06a20).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/threading.py 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##           potel-base    #4308      +/-   ##
==============================================
- Coverage       84.37%   84.34%   -0.04%     
==============================================
  Files             144      144              
  Lines           14629    14624       -5     
  Branches         2325     2324       -1     
==============================================
- Hits            12343    12334       -9     
- Misses           1559     1563       +4     
  Partials          727      727
Files with missing lines Coverage Δ
sentry_sdk/integrations/threading.py 86.44% <33.33%> (-5.75%) ⬇️

... and 2 files with indirect coverage changes

@sentrivana sentrivana deleted the ivana/potel/remove-propagate-scopes-from-threading branch October 20, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sentrivana